<html>
<head><meta charset="utf-8"><title>refactor types #42340 · wg-traits · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/index.html">wg-traits</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/refactor.20types.20.2342340.html">refactor types #42340</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="177060399"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/refactor%20types%20%2342340/near/177060399" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/refactor.20types.20.2342340.html#177060399">(Oct 01 2019 at 14:27)</a>:</h4>
<p>Hey <span class="user-mention" data-user-id="116773">@csmoe</span> -- just saw your PR <a href="https://github.com/rust-lang/rust/issues/64817" target="_blank" title="https://github.com/rust-lang/rust/issues/64817">#64817</a> -- funny you should open that, as in thinking things through last night I had identified <a href="https://github.com/rust-lang/rust/issues/42340" target="_blank" title="https://github.com/rust-lang/rust/issues/42340">#42340</a> as one of the first projects we should focus on in/around wg-traits.</p>



<a name="177060408"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/refactor%20types%20%2342340/near/177060408" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/refactor.20types.20.2342340.html#177060408">(Oct 01 2019 at 14:28)</a>:</h4>
<p>I'll take a look!</p>



<a name="177060469"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/refactor%20types%20%2342340/near/177060469" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/refactor.20types.20.2342340.html#177060469">(Oct 01 2019 at 14:28)</a>:</h4>
<p>And yes, I'm behind on reviewing =)</p>



<a name="177093367"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/refactor%20types%20%2342340/near/177093367" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/refactor.20types.20.2342340.html#177093367">(Oct 01 2019 at 20:13)</a>:</h4>
<p>I'm reading this now.</p>



<a name="177093386"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/refactor%20types%20%2342340/near/177093386" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/refactor.20types.20.2342340.html#177093386">(Oct 01 2019 at 20:13)</a>:</h4>
<p>I'm also thinking about <span class="user-mention" data-user-id="128294">@blitzerr</span>'s branch and shedding a small tear</p>



<a name="177093409"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/refactor%20types%20%2342340/near/177093409" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/refactor.20types.20.2342340.html#177093409">(Oct 01 2019 at 20:13)</a>:</h4>
<p>maybe after you land this PR <span class="user-mention" data-user-id="116773">@csmoe</span> you might want to take a stab at doing the "RFC 2229" refactoring :)</p>



<a name="177094509"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/refactor%20types%20%2342340/near/177094509" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> blitzerr <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/refactor.20types.20.2342340.html#177094509">(Oct 01 2019 at 20:24)</a>:</h4>
<blockquote>
<p>I'm also thinking about <span class="user-mention silent" data-user-id="128294">blitzerr</span>'s branch and shedding a small tear</p>
</blockquote>
<p><span class="user-mention" data-user-id="116009">@nikomatsakis</span> Its unfortunate. I will resume that after the traits and future issues are done</p>



<a name="177094765"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/refactor%20types%20%2342340/near/177094765" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/refactor.20types.20.2342340.html#177094765">(Oct 01 2019 at 20:27)</a>:</h4>
<p><span class="user-mention" data-user-id="116773">@csmoe</span> <a href="https://github.com/rust-lang/rust/pull/64817#pullrequestreview-295869641" target="_blank" title="https://github.com/rust-lang/rust/pull/64817#pullrequestreview-295869641">left a review here</a></p>



<a name="177627947"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/refactor%20types%20%2342340/near/177627947" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> csmoe <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/refactor.20types.20.2342340.html#177627947">(Oct 08 2019 at 15:34)</a>:</h4>
<blockquote>
<p>maybe after you land this PR <span class="user-mention silent" data-user-id="116773">csmoe</span> you might want to take a stab at doing the "RFC 2229" refactoring <span aria-label="slight smile" class="emoji emoji-1f642" role="img" title="slight smile">:slight_smile:</span></p>
</blockquote>
<p><span class="user-mention" data-user-id="116009">@nikomatsakis</span>  closure/generator were doned. for "refactoring", did you mean rebasing blitzerr's paused branch onto master or else?</p>



<a name="177628920"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/refactor%20types%20%2342340/near/177628920" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/refactor.20types.20.2342340.html#177628920">(Oct 08 2019 at 15:44)</a>:</h4>
<p><span class="user-mention" data-user-id="116773">@csmoe</span> good question. What I meant by that comment was yes, rebasing (or, more likely, reimplementing) <span class="user-mention" data-user-id="128294">@blitzerr</span>'s branch</p>



<a name="177628943"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/refactor%20types%20%2342340/near/177628943" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/refactor.20types.20.2342340.html#177628943">(Oct 08 2019 at 15:44)</a>:</h4>
<p>But I was also thinking that in terms of <a href="https://github.com/rust-lang/rust/issues/42340" target="_blank" title="https://github.com/rust-lang/rust/issues/42340">#42340</a> it'd be good to start a "design document" with what we think types <em>should</em> look like</p>



<a name="177628958"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/refactor%20types%20%2342340/near/177628958" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/refactor.20types.20.2342340.html#177628958">(Oct 08 2019 at 15:44)</a>:</h4>
<p>I think the structure outlined in the issue is too simplistic</p>



<a name="177628963"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/refactor%20types%20%2342340/near/177628963" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/refactor.20types.20.2342340.html#177628963">(Oct 08 2019 at 15:44)</a>:</h4>
<p>chalk is probably pretty close to the right "overall shape"</p>



<a name="177633901"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/refactor%20types%20%2342340/near/177633901" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> csmoe <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/refactor.20types.20.2342340.html#177633901">(Oct 08 2019 at 16:36)</a>:</h4>
<blockquote>
<p><span class="user-mention silent" data-user-id="116773">csmoe</span> good question. What I meant by that comment was yes, rebasing (or, more likely, reimplementing) <span class="user-mention silent" data-user-id="128294">blitzerr</span>'s branch</p>
</blockquote>
<p>okay, any updates on the previous implementation approach? or I will review the doc on dropbox.</p>



<a name="177635451"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/refactor%20types%20%2342340/near/177635451" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> csmoe <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/refactor.20types.20.2342340.html#177635451">(Oct 08 2019 at 16:55)</a>:</h4>
<p>ohh, wait, before restarting, I wanna hear from <span class="user-mention" data-user-id="128294">@blitzerr</span> as they said: "...I will resume that after the traits and furture issues..", may I take over this matter from you?</p>



<a name="177636209"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/refactor%20types%20%2342340/near/177636209" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> csmoe <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/refactor.20types.20.2342340.html#177636209">(Oct 08 2019 at 17:02)</a>:</h4>
<blockquote>
<p>But I was also thinking that in terms of <a href="https://github.com/rust-lang/rust/issues/42340" target="_blank" title="https://github.com/rust-lang/rust/issues/42340">#42340</a> it'd be good to start a "design document" with what we think types <em>should</em> look like</p>
</blockquote>
<p><span class="user-mention" data-user-id="116009">@nikomatsakis</span>  sorry, I'm incapable to provide valuable ideas on such "design document" but eager to volunteer, so need help from your seniors to sketch out  that.</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>